| From: | Sami Imseih <samimseih(at)gmail(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Yura Sokolov <y(dot)sokolov(at)postgrespro(dot)ru>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix bug in multixact Oldest*MXactId initialization and access |
| Date: | 2026-03-02 19:09:07 |
| Message-ID: | CAA5RZ0s3wL+4RJRRtJVK1VxEgAmYrj7ftfSuAJHJ+oDfTabQbg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> > It says “Each is indexed by ProcNumber”, but it’s no longer accurate for OldestMemberMXactId prepared-xact entries, which now use index (procno - FIRST_PREPARED_XACT_PROC_NUMBER).
>
> Fixed those and some other comment work, and pushed. Thanks!
>
Thanks! what are your thoughts about adding a test like the one
here [1] ? This allows us to test correct handling of prepared
transaction dummy procs. The asserts added will not cover
this case.
What do you think?
--
Sami Imseih
Amazon Web Services (AWS)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2026-03-02 19:23:32 | Re: Compiler warning when using TRGM_REGEXP_DEBUG |
| Previous Message | Greg Burd | 2026-03-02 19:08:50 | Re: Expanding HOT updates for expression and partial indexes |