Re: Issue with logical replication slot during switchover

From: Fabrice Chapuis <fabrice636861(at)gmail(dot)com>
To: shveta malik <shveta(dot)malik(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>
Subject: Re: Issue with logical replication slot during switchover
Date: 2025-10-03 07:58:35
Message-ID: CAA5-nLB822QxuU3AyXxKKO6tcQZavY_dhUBPXZhRMzvJ3H6RQQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Shveta,
Here is the v4 of the patch with pg_replication_slots view modified to
display the field allow_overwrite. Doc was also updated.

Regards,

Fabrice

On Tue, Sep 30, 2025 at 11:45 AM shveta malik <shveta(dot)malik(at)gmail(dot)com>
wrote:

> On Tue, Sep 30, 2025 at 3:11 PM shveta malik <shveta(dot)malik(at)gmail(dot)com>
> wrote:
> >
> > On Tue, Sep 30, 2025 at 12:17 PM Fabrice Chapuis
> > <fabrice636861(at)gmail(dot)com> wrote:
> > >
> > > Hi,
> > >
> > > Here the generated v2 of the Patch.
> > >
> >
> > Thanks. I have refactored the code for synchronize_one_slot() as there
> > was some code-repetition. Please take it if you find it okay.
> >
> > Also I felt that when we create a slot through slot-synchronization,
> > we should create it with allow_overwrite as false. And thus in the
> > attached patch, I have changed that part as well.
> >
> > It is a top up patch. Attached it as txt, please rename before
> > applying atop your changes. Attached the steps for your reference.
> >
>
> Next, pg_replication_slots (pg_get_replication_slots) can be modified
> to display the new property. And the corresponding doc for
> pg_replication_slots (doc/src/sgml/system-views.sgml) can be updated.
>
> thanks
> Shveta
>

Attachment Content-Type Size
v4-0001-Add-allow_overwrite-option-to-logical-replication.patch text/x-patch 12.8 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2025-10-03 08:04:17 Re: Support getrandom() for pg_strong_random() source
Previous Message Michael Paquier 2025-10-03 07:50:07 Re: Add stats_reset to pg_stat_all_tables|indexes and related views