| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Tristen Raab <tristen(dot)raab(at)highgo(dot)ca> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Subject: | Re: Documentation: warn about two_phase when altering a subscription |
| Date: | 2024-03-11 04:15:27 |
| Message-ID: | CAA4eK1LwdtLjxT_DBQT2FASQZAUnFu1UCceCmwdOmc=SosuQ7Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Feb 24, 2024 at 5:21 AM Tristen Raab <tristen(dot)raab(at)highgo(dot)ca> wrote:
>
> I've reviewed your patch, it applies correctly and the documentation builds without any errors. As for the content of the patch itself, I think so far it's good but would make two modifications. I like how the patch was worded originally when referring to the subscription, stating these parameters were 'in' the subscription rather than 'by' it. So I'd propose changing
>
> > parameters specified by the subscription. When creating the slot, ensure
>
> to
>
> > parameters specified in the subscription. When creating the slot, ensure
>
This suggestion makes sense, so I updated the patch for this and committed.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hayato Kuroda (Fujitsu) | 2024-03-11 05:03:07 | RE: speed up a logical replica setup |
| Previous Message | vignesh C | 2024-03-11 04:12:06 | Re: speed up a logical replica setup |