Re: repeated decoding of prepared transactions

On Wed, Feb 24, 2021 at 5:06 PM Ajin Cherian <itsajin(at)gmail(dot)com> wrote:
>
> On Wed, Feb 24, 2021 at 4:48 PM Ajin Cherian <itsajin(at)gmail(dot)com> wrote:
>
> > I plan to split this into two patches next. But do review and let me
> > know if you have any comments.
>
> Attaching an updated patch-set with the changes for
> snapshot_was_exported_at_lsn separated out from the changes for the
> APIs pg_create_logical_replication_slot() and
> pg_logical_slot_get_changes(). Along with a rebase that takes in a few
> more commits since my last patch.
>

Few comments on the first patch:
1. We can't remove ReorderBufferSkipPrepare because we rely on that in
SnapBuildDistributeNewCatalogSnapshot.
2. I have changed the name of the variable from
snapshot_was_exported_at_lsn to snapshot_was_exported_at but I am
still not very sure about this naming because there are times when we
don't export snapshot and we still set this like when creating slots
with CRS_NOEXPORT_SNAPSHOT or when creating via SQL APIs. The other
name that comes to mind is initial_consistency_at, what do you think?
3. Changed comments at various places.

Please find the above changes as a separate patch, if you like you can
include these in the main patch.

Apart from the above, I think the comments related to docs in my
previous email [1] are still valid, can you please take care of those.

[1] - https://www.postgresql.org/message-id/CAA4eK1Kr34_TiREr57Wpd%3D3%3D03x%3D1n55DAjwJPGpHAEc4dWfUQ%40mail.gmail.com

--
With Regards,
Amit Kapila.