| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Ryan Lambert <ryan(at)rustprooflabs(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Anthony Nowocien <anowocien(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Filip Rembiałkowski <filip(dot)rembialkowski(at)gmail(dot)com> |
| Subject: | Re: dropdb --force |
| Date: | 2019-11-28 03:23:56 |
| Message-ID: | CAA4eK1LuH2GcREcB2VDecp1bbyDh53M43nxZ8X2cg=mArOsd5Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Nov 27, 2019 at 10:15 AM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
>
> Attached patch has the fixes for the above comments.
>
I have pushed the refactoring patch. In the second patch, I have a
few more comments. I am not completely sure if it is a good idea to
write a new test file 060_dropdb_force.pl when we already have an
existing file 050_dropdb.pl for dropdb tests, but I think if we want
to do that, then lets move existing test for dropdb '-f' from
050_dropdb.pl to new file and it might be better to name new file as
051_dropdb_force.pl. I see that in some other cases like vacuumdb and
clusterdb, we have separate test files to cover a different kinds of
scenarios, so it should be okay to have a new file for dropdb tests.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Artur Zakirov | 2019-11-28 03:29:34 | Re: pg_upgrade fails with non-standard ACL |
| Previous Message | k.jamison@fujitsu.com | 2019-11-28 03:18:59 | RE: [Patch] Optimize dropping of relation buffers using dlist |