Re: Skipping logical replication transactions on subscriber side

On Fri, Nov 19, 2021 at 3:00 PM Greg Nancarrow <gregn4422(at)gmail(dot)com> wrote:
>
> On Fri, Nov 19, 2021 at 8:15 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > Yeah in such a case last_error_time can be shown as a time before
> > first_error_time but I don't think that will be a big problem, the
> > next message will fix it. I don't see what we can do about it and the
> > same is true for other cases like pg_stat_archiver where the success
> > and failure times can be out of order. If we want we can remove one of
> > those times but I don't think this happens frequently enough to be
> > considered a problem. Anyway, these stats are not considered to be
> > updated with the most latest info.
> >
>
> Couldn't the code block in pgstat_recv_subworker_error() that
> increments error_count just compare the new msg timestamp against the
> existing first_error_time and last_error_time and, based on the
> result, update those if required?
>

I don't see any problem with that but let's see what Sawada-San has to
say about this?

--
With Regards,
Amit Kapila.