From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
Cc: | Greg Nancarrow <gregn4422(at)gmail(dot)com>, "osumi(dot)takamichi(at)fujitsu(dot)com" <osumi(dot)takamichi(at)fujitsu(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Alexey Lesovsky <lesovsky(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Skipping logical replication transactions on subscriber side |
Date: | 2021-08-19 12:14:42 |
Message-ID: | CAA4eK1Lk8ekC9a_191VLzmaHYT1HRhWx2YdqcRxZBNrOcpApWA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Aug 19, 2021 at 12:47 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> On Tue, Aug 17, 2021 at 12:00 PM Greg Nancarrow <gregn4422(at)gmail(dot)com> wrote:
> >
>
> > Another comment on the 0001 patch: as there is now a mix of setting
> > "apply_error_callback_arg" members directly and also through inline
> > functions, it might look better to have it done consistently with
> > functions having prototypes something like the following:
> >
> > static inline void set_apply_error_context_rel(LogicalRepRelMapEntry *rel);
> > static inline void reset_apply_error_context_rel(void);
> > static inline void set_apply_error_context_attnum(int remote_attnum);
>
> It might look consistent, but if we do that, we will end up needing
> functions every field to update when we add new fields to the struct
> in the future?
>
Yeah, I also think it is too much, but we can add comments where ever
we set the information for error callback. I see it is missing when
the patch is setting remote_attnum, see similar other places and add
comments if already not there.
--
With Regards,
Amit Kapila.
From | Date | Subject | |
---|---|---|---|
Next Message | Masahiko Sawada | 2021-08-19 12:20:38 | Showing I/O timings spent reading/writing temp buffers in EXPLAIN |
Previous Message | Jelte Fennema | 2021-08-19 11:50:09 | Allow declaration after statement and reformat code to use it |