Re: row filtering for logical replication

On Thu, Jan 20, 2022 at 5:03 PM tanghy(dot)fnst(at)fujitsu(dot)com
<tanghy(dot)fnst(at)fujitsu(dot)com> wrote:
>
> On Thu, Jan 20, 2022 9:13 AM houzj(dot)fnst(at)fujitsu(dot)com <houzj(dot)fnst(at)fujitsu(dot)com> wrote:
> > Attach the V68 patch set which addressed the above comments and changes.
> > The version patch also fix the error message mentioned by Greg[1]
> >
>
> I saw a problem about this patch, which is related to Replica Identity check.
>
> For example:
> -- publisher --
> create table tbl (a int);
> create publication pub for table tbl where (a>10) with (publish='delete');
> insert into tbl values (1);
> update tbl set a=a+1;
>
> postgres=# update tbl set a=a+1;
> ERROR: cannot update table "tbl"
> DETAIL: Column "a" used in the publication WHERE expression is not part of the replica identity.
>
> I think it shouldn't report the error because the publication didn't publish UPDATES.
>

Right, I also don't see any reason why an error should be thrown in
this case. The problem here is that the patch doesn't have any
correspondence between the pubaction and RI column validation for a
particular publication. I think we need to do that and cache that
information unless the publication publishes both updates and deletes
in which case it is okay to directly return invalid column in row
filter as we are doing now.

--
With Regards,
Amit Kapila.