Re: PG compilation error with Visual Studio 2015/2017/2019

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com>, davinder singh <davindersingh2692(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
Subject: Re: PG compilation error with Visual Studio 2015/2017/2019
Date: 2020-04-20 04:40:40
Message-ID: CAA4eK1LaT=0JZ3shApsK0UEz4EKauJmdZ=+U+nz7i5T9nHy9ZA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Apr 20, 2020 at 4:32 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Sun, Apr 19, 2020 at 03:59:50PM -0300, Ranier Vilela wrote:
> > Em dom., 19 de abr. de 2020 às 12:34, Juan José Santamaría Flecha <
> > juanjo(dot)santamaria(at)gmail(dot)com> escreveu:
> >> This line needs a break, other than that LGTM.
> >
> > Sure. Attached new patch with this revision.
>
> Amit, are you planning to look at this patch?
>

Yes, I am planning to look into it. Actually, I think the main thing
here is to ensure that we don't break something which was working with
_create_locale API.

> I may be able to spend
> a couple of hours on this thread this week and that's an area of the
> code I have worked with in the past, though I am not sure.
>

Okay, that will be good.

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2020-04-20 05:27:27 Re: While restoring -getting error if dump contain sql statements generated from generated.sql file
Previous Message Amit Kapila 2020-04-20 04:15:18 Re: where should I stick that backup?