From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | vignesh C <vignesh21(at)gmail(dot)com> |
Cc: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com>, "Yu Shi (Fujitsu)" <shiy(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Add two missing tests in 035_standby_logical_decoding.pl |
Date: | 2023-05-04 04:43:17 |
Message-ID: | CAA4eK1La2uVZdSNdp_AwpxVP85SvWHMT3ecfJgVYqPMjGVViyw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, May 4, 2023 at 8:37 AM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> Thanks for posting the updated patch, I had run this test in a loop of
> 100 times to verify that there was no failure because of race
> conditions. The 100 times execution passed successfully.
>
> One suggestion:
> "wal file" should be changed to "WAL file":
> +# Request a checkpoint on the standby to trigger the WAL file(s) removal
> +$node_standby->safe_psql('postgres', 'checkpoint;');
> +
> +# Verify that the wal file has not been retained on the standby
> +my $standby_walfile = $node_standby->data_dir . '/pg_wal/' . $walfile_name;
>
Thanks for the verification. I have pushed the patch.
--
With Regards,
Amit Kapila.
From | Date | Subject | |
---|---|---|---|
Next Message | Nathan Bossart | 2023-05-04 04:54:13 | Re: PL/Python: Fix return in the middle of PG_TRY() block. |
Previous Message | Ian Lawrence Barwick | 2023-05-04 04:12:49 | Re: "CREATE RULE ... ON SELECT": redundant? |