| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: A recent message added to pg_upgade |
| Date: | 2023-10-27 04:06:13 |
| Message-ID: | CAA4eK1L_=y2UVXDCHcMz-17v1yX2sSOuTmJHDFETVqy_eR=6tw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Oct 27, 2023 at 8:52 AM Bharath Rupireddy
<bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
>
> On Fri, Oct 27, 2023 at 8:28 AM Kyotaro Horiguchi:
> The above errhint LGTM. How about a slightly different errmsg, like
> the following?
>
> + errmsg("cannot invalidate replication slots when
> in binary upgrade mode"),
> + errhint("Set \"max_slot_wal_keep_size\" to -1 to
> avoid invalidation."));
>
> ".... when in binary upgrade mode" is being used in many places.
>
By this time slot may be already invalidated, so how about:
"replication slot was invalidated when in binary upgrade mode"?
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2023-10-27 04:06:50 | Re: A recent message added to pg_upgade |
| Previous Message | jian he | 2023-10-27 03:45:44 | maybe a type_sanity. sql bug |