Re: WIP: Avoid creation of the free space map for small tables

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: John Naylor <john(dot)naylor(at)2ndquadrant(dot)com>
Cc: Mithun Cy <mithun(dot)cy(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: WIP: Avoid creation of the free space map for small tables
Date: 2019-03-14 14:16:41
Message-ID: CAA4eK1LZpmPofW4sCuDqo=Bog7zTY2JrZYWjN7mS8LokfJbu9g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Mar 14, 2019 at 12:37 PM John Naylor
<john(dot)naylor(at)2ndquadrant(dot)com> wrote:
>
> On Thu, Mar 14, 2019 at 2:17 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > 1. Added an Assert in new_cluster_needs_fsm() that old cluster version
> > should be >= 804 as that is where fsm support has been added.
>
> There is already an explicit check for 804 in the caller,
>

Yeah, I know that, but I have added it to prevent this function being
used elsewhere. OTOH, maybe you are right that as per current code it
is superfluous, so we shouldn't add this assert.

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2019-03-14 14:23:59 Re: Offline enabling/disabling of data checksums
Previous Message Thibaut 2019-03-14 14:10:53 Re: Problem with default partition pruning