Re: Hash index: stop registering pin-only bucket pages in WAL (remove REGBUF_NO_CHANGE)

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Greg Burd <greg(at)burd(dot)me>
Cc: Hayato Kuroda <kuroda(dot)hayato(at)fujitsu(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Joao Rito <joaovictor(dot)rito(at)gmail(dot)com>, shihao zhong <zhong950419(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Jeff Davis <pgsql(at)j-davis(dot)com>, Alexander Lakhin <exclusion(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Hash index: stop registering pin-only bucket pages in WAL (remove REGBUF_NO_CHANGE)
Date: 2026-11-16 10:52:59
Message-ID: CAA4eK1LNNnxyg2Mq2BvktJoUqLrSz_vAWW-gKceYao4=ewdJqQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Nov 15, 2026 at 2:06 AM Greg Burd <greg(at)burd(dot)me> wrote:
>
> Hayato, vignesh, Joao,
>
> v12 attached. Same series as v11, with one fix: the new torn-page test
> failed CI on 32-bit, and this corrects it. Code is unchanged from v11.
>

I don't think we want to commit the test to create a torn-page as it
appears complex and not sure if we have any other similar test though
it is good to use for testing the fix. I suggest let's first commit
the fix for torn-page reads issue (Fix hash index redo reading a torn
primary bucket page) as that needs to be backpatched. Once that is
committed, we can look at HEAD-only code improvements separately. If
we agree on this, can one of you separate out the test and share
bug-fix patches?

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jakub Wartak 2026-11-16 11:20:15 Re: amcheck: add index-all-keys-match verification for B-Tree
Previous Message Magnus Hagander 2026-11-16 10:48:46 Re: Key joins