Re: [16+] subscription can end up in inconsistent state

On Wed, Sep 13, 2023 at 2:04 AM Jeff Davis <pgsql(at)j-davis(dot)com> wrote:
>
> On Tue, 2023-09-12 at 16:13 +0530, Amit Kapila wrote:
> > Do we want to remove
> > that as anyway, we will do that check via walrcv_connect()?
>
> I think we should keep the DDL-time checks in place as a best-effort,
> but not rely on them for security.
>
> > Another point is that if we want to unify such a check at the time of
> > walrcv_connect() then do we need to do it at the time of Alter
> > Subscription? I think it will probably be better to catch the problem
> > early
>
> Agreed. Catching mistakes at DDL time is a better user experience.
>
> > but does removing it from Alter Subscription time and doing it
> > at connect time lead to security hazards?
>
> We'd still be doing the same check, just later, right?
>

Right.

--
With Regards,
Amit Kapila.