| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: POC: Cleaning up orphaned files using undo logs |
| Date: | 2019-07-25 02:18:07 |
| Message-ID: | CAA4eK1LKimEMDzt8D39j_oSwOXD7YfoZYq7UQsAPQ4400T+o=A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jul 24, 2019 at 11:04 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> Hi,
>
> I have done some review of undolog patch series
> and here are my comments:
> 0003-Add-undo-log-manager.patch
>
> 1) As undo log is being created in tablespace,
> if the tablespace is dropped later, will it have any impact?
>
Yes, it drops the undo logs present in tablespace being dropped. See
DropUndoLogsInTablespace() in the same patch.
>
> 4) Should we add a readme file for undolog as it does a fair amount of work
> and is core part of the undo system?
>
The Readme is already present in the patch series posted by Thomas.
See 0019-Add-developer-documentation-for-the-undo-log-storage.patch in
email [1].
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-07-25 03:11:45 | Re: dropdb --force |
| Previous Message | Tom Lane | 2019-07-25 02:00:09 | Re: benchmarking Flex practices |