Re: Reducing ClogControlLock contention

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Reducing ClogControlLock contention
Date: 2015-08-26 10:40:37
Message-ID: CAA4eK1LJkAhn9uqejMXBNc+Dp-q-+ZEXnc0x=bzh-s3407A_Nw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Aug 25, 2015 at 2:21 PM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:

> On 22 August 2015 at 15:14, Andres Freund <andres(at)anarazel(dot)de> wrote:
>

> TransactionIdSetPageStatus() calls TransactionIdSetStatusBit(), which
>> writes an 8 byte variable (the lsn). That's not safe.
>>
>
> Agreed, thanks for spotting that.
>
> I see this as the biggest problem to overcome with this patch.
>

How about using 64bit atomics or spinlock to protect this variable?

With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2015-08-26 10:48:13 Re: Reducing ClogControlLock contention
Previous Message Etsuro Fujita 2015-08-26 10:39:18 Re: Foreign join pushdown vs EvalPlanQual