| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Minor patch; missing comment update in worker.c |
| Date: | 2025-06-24 05:11:33 |
| Message-ID: | CAA4eK1LExxA9zM6jZkQwCMQWHwWMaKwOht=C0f--sDWpdaOYtQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jun 23, 2025 at 8:56 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Mon, Jun 23, 2025 at 8:22 AM Hayato Kuroda (Fujitsu)
> <kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
> >
> > But this is not correct anymore, 1462aad2 allows to alter two_phase option.
> > I was an original author, but I did oversight.
> >
> > I feel it can be fixed by referring the commit message, attached patch fixed like
> > that. How do you feel?
> >
>
> Thanks for the report and patch. I'll look into it.
>
We can now completely remove that comment, as the necessary details
are already present in subscriptioncmds.c. I have done that and pushed
the patch. Thanks.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sutou Kouhei | 2025-06-24 05:11:50 | Re: Make COPY format extendable: Extract COPY TO format implementations |
| Previous Message | Michael Paquier | 2025-06-24 05:10:55 | Re: problems with toast.* reloptions |