| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | shveta malik <shveta(dot)malik(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Euler Taveira <euler(at)eulerto(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org> |
| Subject: | Re: Logical Replication of sequences |
| Date: | 2025-10-08 09:10:21 |
| Message-ID: | CAA4eK1LDWDZMu_o=o22VdWJOuFhNTSoD-aFoceHRXvEiJmP1OA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Oct 7, 2025 at 4:52 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> Thanks for the comments, the attached patch has the changes for the same.
>
parse_publication_options(ParseState *pstate,
List *options,
+ bool allsequences,
+ bool alltables,
bool *publish_given,
PublicationActions *pubactions,
bool *publish_via_partition_root_given,
bool *publish_via_partition_root,
bool *publish_generated_columns_given,
- char *publish_generated_columns)
+ char *publish_generated_columns,
+ bool def_pub_action)
{
…
+
+ if (allsequences &&
+ (*publish_given || *publish_via_partition_root_given ||
+ *publish_generated_columns_given))
+ {
+ if (!alltables)
+ ereport(ERROR,
+ errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE),
+ errmsg("publication parameters are not applicable for publications
defined as FOR ALL SEQUENCES"));
I think we can let users specify publication parameters even for
sequence_only publication as well. Because users could then later add
tables to it by Alter Publication .. Add .. The notice should be
sufficient and also then it would bebetter to give it outside this
function as that could be extended in future when we would allow a mix
of sequence and table publications.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2025-10-08 09:11:27 | Re: Logical Replication of sequences |
| Previous Message | Erik Wienhold | 2025-10-08 09:09:52 | Re: psql: Count all table footer lines in pager setup |