| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com> |
| Cc: | Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Resetting spilled txn statistics in pg_stat_replication |
| Date: | 2020-10-06 08:56:29 |
| Message-ID: | CAA4eK1LBNvWyKQJXNkTh4XzEzzDeQeGbKGKeWHOyQdPbpSGx6g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Oct 6, 2020 at 9:34 AM Masahiko Sawada
<masahiko(dot)sawada(at)2ndquadrant(dot)com> wrote:
>
> Looking at pgstat_reset_replslot_counter() in the v8 patch, even if we
> pass a physical slot name to pg_stat_reset_replication_slot() a
> PgStat_MsgResetreplslotcounter is sent to the stats collector. I’m
> okay with not raising an error but maybe we can have it not to send
> the message in that case.
>
makes sense, so changed accordingly.
--
With Regards,
Amit Kapila.
| Attachment | Content-Type | Size |
|---|---|---|
| v9-0001-Track-statistics-for-spilling-of-changes-from-Reo.patch | application/octet-stream | 41.3 KB |
| v9-0002-Test-stats.patch | application/octet-stream | 4.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2020-10-06 09:27:36 | pg_upgrade dead code for pre-8.4 versions |
| Previous Message | Takashi Menjo | 2020-10-06 08:49:13 | RE: [PoC] Non-volatile WAL buffer |