Re: Resetting spilled txn statistics in pg_stat_replication

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Resetting spilled txn statistics in pg_stat_replication
Date: 2020-06-02 09:34:39
Message-ID: CAA4eK1L8BtNmyjdah=+-NueSMKNAzNC2CTrdf-0hPPA3LAQ_CQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jun 2, 2020 at 11:48 AM Masahiko Sawada
<masahiko(dot)sawada(at)2ndquadrant(dot)com> wrote:
>
> Hi all,
>
> Tracking of spilled transactions has been introduced to PG13. These
> new statistics values, spill_txns, spill_count, and spill_bytes, are
> cumulative total values unlike other statistics values in
> pg_stat_replication. How can we reset these values? We can reset
> statistics values in other statistics views using by
> pg_stat_reset_shared(), pg_stat_reset() and so on. It seems to me that
> the only option to reset spilled transactions is to restart logical
> replication but it's surely high cost.
>

I see your point but I don't see a pressing need for such a function
for PG13. Basically, these counters will be populated when we have
large transactions in the system so not sure how much is the use case
for such a function. Note that we need to add additional column
stats_reset in pg_stat_replication view as well similar to what we
have in pg_stat_archiver and pg_stat_bgwriter. OTOH, I don't see any
big reason for not having such a function for PG14.

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2020-06-02 09:38:36 Re: Resetting spilled txn statistics in pg_stat_replication
Previous Message Антон Пацев 2020-06-02 09:33:33 Re: Proposal: remove string "contains errors; unaffected changes were applied"