| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: error context for vacuum to include block number |
| Date: | 2020-04-01 02:24:45 |
| Message-ID: | CAA4eK1L56pO7rM6CGcTwg5DCfuK2gZXLA1mV6S8_EghtBTJNvw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 31, 2020 at 8:53 AM Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
>
> On Tue, Mar 31, 2020 at 07:50:45AM +0530, Amit Kapila wrote:
> > One thing I have noticed is that there is some saving by using
> > vacrelstats->relnamespace as that avoids sys cache lookup. OTOH,
> > using vacrelstats->relname doesn't save much, but maybe for the sake
> > of consistency, we can use it.
>
> Mostly I wrote that to avoid repeatedly calling functions/macro with long name.
> I consider it a minor cleanup. I think we should put them to use. The
> LVRelStats describes them as not being specifically for the error context.
>
Pushed. I think we are done here. The patch is marked as committed in
CF. Thank you!
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2020-04-01 02:26:38 | Re: Issues with building cpp extensions on PostgreSQL 10+ |
| Previous Message | Michael Paquier | 2020-04-01 02:19:14 | Re: [Patch] pg_rewind: options to use restore_command from recovery.conf or command line |