Re: Distinguish publication exclusions in object addresses

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Peter Smith <smithpb2250(at)gmail(dot)com>
Cc: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Distinguish publication exclusions in object addresses
Date: 2026-09-16 07:41:15
Message-ID: CAA4eK1L3VrOBRCfT1aJZGViK6RHqxZ4SecByFAQu_PODerEdLw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Sep 16, 2026 at 12:23 PM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> On Wed, Sep 16, 2026 at 4:46 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> >
> >
> >
> > > On Sep 16, 2026, at 13:50, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > >
> > > --
> > > With Regards,
> > > Amit Kapila.
> > > <v4-0001-Distinguish-publication-exclusions-in-object-addr.patch>
> >
> > V4 overall looks sold to me. Just a couple of small comments:
> >
> > 1
> > ```
> > -- No entry of either kind. testpub_default publishes nothing.
> > SELECT pg_get_object_address('publication excluded relation',
> > '{public, testpub_tbl1}', '{testpub_default}');
> > ERROR: publication relation "testpub_tbl1" in publication "testpub_default" does not exist
> > ```
> >
> > For this new test, the error message is a little surprising to me. Since the requested object type is "publication excluded relation", I would expect the error message to say something like:
> > ```
> > publication excluded relation "testpub_tbl1" in publication "testpub_default" does not exist
> > ```
>
> +1 this because maybe the reported table name really *does* exist and
> is part of the publication, even though the message is saying the
> exact opposite.
>

Can you share an example of such a case?

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ewan Young 2026-09-16 07:43:58 Re: ERROR: no relation entry for relid 3
Previous Message vignesh C 2026-09-16 07:37:36 Re: Distinguish publication exclusions in object addresses