| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Zhijie Hou <houzhijie22(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Mihail Nikalayeu <mihailnikalayeu(at)gmail(dot)com>, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, vignesh C <vignesh21(at)gmail(dot)com>, "ashutosh(dot)bapat(dot)oss(at)gmail(dot)com" <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, shveta malik <shvetamalik(at)gmail(dot)com> |
| Subject: | Re: Crashes on a partition whose concurrent detach never finished |
| Date: | 2026-11-13 04:57:47 |
| Message-ID: | CAA4eK1L0UpMPKmHmMPMESB8+o_HrOJ-FguxFWjO1qOr+whKnmg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 12, 2026 at 4:40 PM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>
> On 2026-Nov-12, Zhijie Hou wrote:
>
> > Since there's only one publication in this file, I think the current name is
> > fine as we don't need to distinguish it from any other publication. Similar
> > names are also used in other tests.
>
> Right now, isolation tests run one after the other, so you're right that
> this name doesn't really matter much. However, someday it might be nice
> if we can make (some of) them run in parallel. We tried to do that eons
> ago, couldn't find the time to implement it, idea was forgotten. If
> that effort ever takes off again it would be nice if we don't have to
> fix a thousand pointless name conflicts of this kind. (We already have
> enough of those that we'll have to fix.) So I think Shveta had the
> right idea here.
>
Fair enough, now that I have committed the patch, is it worth
considering to change the name in HEAD-only?
BTW, it will be helpful to get some feedback from you on the 0004
patch in email [1] as that directly touches the detach partition ...
concurrently code path. You might want to read the email [2] to
understand the issue 0004 patch is trying to solve.
[1]: https://www.postgresql.org/message-id/CADzfLwU97r3QC5oZDeVcWvcvXhNy9VnoFNDVHw%2BERg_DEG4%3DFQ%40mail.gmail.com
[2]: https://www.postgresql.org/message-id/CABdArM4fJ8JAWyP0MAF%3D8n66M6%3DCouUmtSGwqizn2pD%3DgfPEZw%40mail.gmail.com
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Keyerror Smart | 2026-11-13 05:53:32 | Re: [PATCH] Consider window functions when reordering GROUP BY items |
| Previous Message | Zhijie Hou | 2026-11-13 03:58:10 | Document prepared transaction lock waits with two_phase subscriptions |