| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | "k(dot)jamison(at)fujitsu(dot)com" <k(dot)jamison(at)fujitsu(dot)com> |
| Cc: | "tsunakawa(dot)takay(at)fujitsu(dot)com" <tsunakawa(dot)takay(at)fujitsu(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, "tgl(at)sss(dot)pgh(dot)pa(dot)us" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, "andres(at)anarazel(dot)de" <andres(at)anarazel(dot)de>, "robertmhaas(at)gmail(dot)com" <robertmhaas(at)gmail(dot)com>, "tomas(dot)vondra(at)2ndquadrant(dot)com" <tomas(dot)vondra(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [Patch] Optimize dropping of relation buffers using dlist |
| Date: | 2020-11-18 12:04:31 |
| Message-ID: | CAA4eK1KtnMrX+eh+2yHCFQ-Ns7O+jj_ukiy2zajwuXnNwNT8xQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Nov 18, 2020 at 2:34 PM k(dot)jamison(at)fujitsu(dot)com
<k(dot)jamison(at)fujitsu(dot)com> wrote:
>
> On Thursday, November 12, 2020 1:14 PM, Tsunakawa-san wrote:
> I forgot to reply.
> Thank you very much Tsunakawa-san for testing and to everyone
> who has provided their reviews and insights as well.
>
> Now thinking about smgrnblocks(), currently Thomas Munro is also working on implementing a
> shared SmgrRelation [1] to store sizes. However, since that is still under development and the
> discussion is still ongoing, I hope we can first commit these set of patches here as these are already
> in committable form. I think it's alright to accept the early improvements implemented in this thread
> to the source code.
>
Yeah, that won't be a bad idea especially because the patch being
discussed in the thread you referred is still in an exploratory phase.
I haven't tested or done a detailed review but I feel there shouldn't
be many problems if we agree on the approach.
Thomas/others, do you have objections to proceeding here? It shouldn't
be a big problem to change the code in this area even if we get the
shared relation size stuff in.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | a.pervushina | 2020-11-18 12:05:00 | Re: [HACKERS] make async slave to wait for lsn to be replayed |
| Previous Message | Antonin Houska | 2020-11-18 11:35:31 | Re: POC: Cleaning up orphaned files using undo logs |