| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Euler Taveira <euler(at)eulerto(dot)com> |
| Cc: | "shveta(dot)malik(at)gmail(dot)com" <shveta(dot)malik(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, shveta malik <shvetamalik(at)gmail(dot)com> |
| Subject: | Re: Include schema-qualified names in publication error messages. |
| Date: | 2026-05-08 09:07:45 |
| Message-ID: | CAA4eK1KsY8qppUKTZ9gRALCojJrj+CM9gLoDxj6CViS99S9JCA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, May 7, 2026 at 6:07 PM Euler Taveira <euler(at)eulerto(dot)com> wrote:
>
> On Thu, May 7, 2026, at 9:36 AM, Amit Kapila wrote:
> > On Thu, May 7, 2026 at 5:50 PM Euler Taveira <euler(at)eulerto(dot)com> wrote:
> >
> > This suggestion sounds reasonable to me but I suggest instead moving
> > this new function to rel.h as an inline function or into relcache.c as
> > those are the places where we take functions with Relation as input.
> > Additionally, we can name the function as
> > RelationGetQualifiedRelationName().
> >
>
> LGTM.
>
Thanks, I've pushed the patch after making required changes.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhenwei Shang | 2026-05-08 09:16:21 | Re: Fix wrong error message from pg_get_tablespace_ddl() |
| Previous Message | Daniel Gustafsson | 2026-05-08 08:54:22 | Re: remove obsolete comment in AtEOXact_Inval |