Re: Incorrect check in 037_except.pl?

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Incorrect check in 037_except.pl?
Date: 2026-07-23 11:05:07
Message-ID: CAA4eK1Krt-_1-v6g+FY0jqOEfgnzYwsTfHnXmtn5VU5NAE6eMA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jul 23, 2026 at 2:55 PM Ayush Tiwari
<ayushtiwari(dot)slg01(at)gmail(dot)com> wrote:
>
> On Thu, 23 Jul 2026 at 12:54, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>>
>> On Wed, Jul 22, 2026 at 10:38 PM Ayush Tiwari
>> <ayushtiwari(dot)slg01(at)gmail(dot)com> wrote:
>> > Yeah you're right, it should likely be the subscriber.
>> >
>> > Same issue appears twice (the "FOR TABLE" and "FOR ALL TABLES" cases);
>> > both need the change.
>>
>> Thanks for the check! Attached patch fixes the issue.
>
>
> Thanks for the patch!
>
> Looks good to me.
>

LGTM as well. Thanks for taking care of this.

--
With Regards,
Amit Kapila.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message John Naylor 2026-07-23 11:09:13 Re: Fix missing FORMAT when deparsing JSON_ARRAY(query)
Previous Message Nitin Jadhav 2026-07-23 10:56:28 Re: Change checkpoint‑record‑missing PANIC to FATAL