| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Euler Taveira <euler(at)eulerto(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org> |
| Subject: | Re: Logical Replication of sequences |
| Date: | 2025-11-05 12:39:48 |
| Message-ID: | CAA4eK1KqWkk5zdwTXBD7RrZSAKFiB=KmAmU6eG=vQNGfdnYJ1g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Nov 5, 2025 at 5:57 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> On Wed, 5 Nov 2025 at 13:58, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > On Mon, Nov 3, 2025 at 8:46 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> > >
> > > The attached v20251103 patch has the changes for the same.
> > >
> >
> > I have pushed the 0001 after making minor adjustments in tests and at
> > a few other places. Kindly rebase and send the remaining patches.
>
> I noticed a buildfarm failure on prion at [1].
> The test failed on prion because it runs with the following additional
> configuration:
> log_error_verbosity = verbose
>
> Due to this setting, the logs include an extra LOCATION line between
> the WARNING and ERROR messages, which was not expected by the test:
> 2025-11-05 11:35:21.090 UTC [1357163:3] WARNING: 55000: mismatched or
> renamed sequence on subscriber ("public.regress_s4")
> 2025-11-05 11:35:21.090 UTC [1357163:4] LOCATION:
> report_sequence_errors, sequencesync.c:185
> 2025-11-05 11:35:21.090 UTC [1357163:5] ERROR: 55000: logical
> replication sequence synchronization failed for subscription
> "regress_seq_sub"
>
> I'm working on a fix for this issue.
>
We can fix it either by expecting just a WARNING for this test which
is sufficient. The other possibility is that we can expect some other
line(s) between WARNING and ERROR. I think just waiting for WARNING in
the log is sufficient as that serves the purpose of this test. What do
you think?
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Matheus Alcantara | 2025-11-05 12:40:38 | Re: LISTEN/NOTIFY bug: VACUUM sets frozenxid past a xid in async queue |
| Previous Message | vignesh C | 2025-11-05 12:27:12 | Re: Logical Replication of sequences |