| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, "Drouvot, Bertrand" <bdrouvot(at)amazon(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "Oh, Mike" <minsoo(at)amazon(dot)com> |
| Subject: | Re: [BUG] Logical replication failure "ERROR: could not map filenode "base/13237/442428" to relation OID" with catalog modifying txns |
| Date: | 2022-08-01 14:31:00 |
| Message-ID: | CAA4eK1KiiXHtj641_G2v7s+S33CVPG9k3OBMVHb3hn+f9YBC7A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Aug 1, 2022 at 7:46 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> On Fri, Jul 29, 2022 at 3:45 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
>
> I've attached updated patches for all branches. Please review them.
>
Thanks, the patches look mostly good to me. I have made minor edits by
removing 'likely' from a few places as those don't seem to be adding
much value, changed comments at a few places, and was getting
compilation in error in v11/10 (snapbuild.c:2111:3: error: ‘for’ loop
initial declarations are only allowed in C99 mode) which I have fixed.
See attached, unless there are major comments/suggestions, I am
planning to push this day after tomorrow (by Wednesday) after another
pass.
--
With Regards,
Amit Kapila.
| Attachment | Content-Type | Size |
|---|---|---|
| master_v11-0001-Fix-catalog-lookup-with-the-wrong-snapshot-durin.patch | application/octet-stream | 29.3 KB |
| REL15_v11-0001-Fix-catalog-lookup-with-the-wrong-snapshot-durin.patch | application/octet-stream | 16.0 KB |
| REL14_v11-0001-Fix-catalog-lookup-with-the-wrong-snapshot-durin.patch | application/octet-stream | 16.0 KB |
| REL13_v11-0001-Fix-catalog-lookup-with-the-wrong-snapshot-durin.patch | application/octet-stream | 16.0 KB |
| REL12_v11-0001-Fix-catalog-lookup-with-the-wrong-snapshot-durin.patch | application/octet-stream | 16.0 KB |
| REL11_v11-0001-Fix-catalog-lookup-with-the-wrong-snapshot-durin.patch | application/octet-stream | 15.9 KB |
| REL10_v11-0001-Fix-catalog-lookup-with-the-wrong-snapshot-durin.patch | application/octet-stream | 15.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dong Wook Lee | 2022-08-01 14:33:38 | Re: Add test of pg_prewarm extenion |
| Previous Message | Tom Lane | 2022-08-01 14:27:57 | Re: Add test of pg_prewarm extenion |