| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Alexander Lakhin <exclusion(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Is this a problem in GenericXLogFinish()? |
| Date: | 2024-02-07 08:38:42 |
| Message-ID: | CAA4eK1KiBbq=jVOJfTE2g=YYOODaWX9i-ix1Wrrufz9gK8F-0Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Feb 5, 2024 at 1:33 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Mon, Feb 05, 2024 at 07:57:09AM +0000, Hayato Kuroda (Fujitsu) wrote:
> > You are right. Based on the previous discussions, PageSetLSN() must be called
> > after the MakeBufferDirty(). REGBUF_NO_CHANGE has been introduced for skipping
> > these requirements. Definitevely, no_change buffers must not be PageSetLSN()'d.
> > Other pages, e.g., metabuf, has already been followed the rule.
>
> At quick glance, this v2 seems kind of right to me: you are setting
> the page LSN only when the page is registered in the record and
> actually dirtied.
>
Thanks for the report and looking into it. Pushed!
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2024-02-07 08:40:54 | Re: Synchronizing slots from primary to standby |
| Previous Message | Bharath Rupireddy | 2024-02-07 08:34:39 | Re: Printing backtrace of postgres processes |