| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Cc: | Erik Rijkers <er(at)xs4all(dot)nl>, Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions |
| Date: | 2020-06-22 11:00:41 |
| Message-ID: | CAA4eK1Ki7scJ0Ch+=Uy7w8Q+o8d1wkX_wTNp6Fb3hGVY1Esvbg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jun 22, 2020 at 4:26 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Thu, Jun 18, 2020 at 9:02 PM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> >
> > Yes, I have made the changes. Basically, now I am only using the
> > XLOG_XACT_INVALIDATIONS for generating all the invalidation messages.
> > So whenever we are getting the new set of XLOG_XACT_INVALIDATIONS, we
> > are directly appending it to the txn->invalidations. I have tested
> > the XLOG_INVALIDATIONS part but while sending this mail I realized
> > that we could write some automated test for the same.
> >
>
> Can you share how you have tested it?
>
> > I will work on
> > that soon.
> >
>
> Cool, I think having a regression test for this will be a good idea.
>
Other than above tests, can we somehow verify that the invalidations
generated at commit time are the same as what we do with this patch?
We have verified with individual commands but it would be great if we
can verify for the regression tests.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2020-06-22 11:10:45 | Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions |
| Previous Message | Josef Šimánek | 2020-06-22 10:57:53 | Re: [PATCH] Initial progress reporting for COPY command |