| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: Hash index bucket split bug |
| Date: | 2026-08-10 10:19:24 |
| Message-ID: | CAA4eK1KgtBDtjXGVBdotLipmbBeOCBzPVFL0xTyx=vbm78yWCA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jul 9, 2026 at 10:02 PM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
>
> I ran this against CI, and saw failures on 32-bit meson tied to tuple
> alignment. When MAXALIGN is 4, the assumptions about page layout
> underlying the test case break.
>
> Attached is V3, which directly addresses the alignment issue, and
> fully passes CI.
>
Thanks, the fixup-patch looks good to me. However, I was thinking
whether it is a good idea to refactor the common code into separate
functions like attached? This is atop your patches. BTW, I took help
from Claude to do this refactoring. I am fine with committing
/sql/hash_split.sql test along with the code-fix.
--
With Regards,
Amit Kapila.
| Attachment | Content-Type | Size |
|---|---|---|
| v3-topup-refactor.txt | text/plain | 6.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nikhil Sontakke | 2026-08-10 10:22:39 | Re: Hot standby accepts connections (giving wrong results) before consistency after crash reset |
| Previous Message | Rafia Sabih | 2026-08-10 10:14:36 | Re: postgres_fdw: Emit message when batch_size is reduced |