Re: Small documentation improvement for ALTER SUBSCRIPTION

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Small documentation improvement for ALTER SUBSCRIPTION
Date: 2021-08-07 06:33:37
Message-ID: CAA4eK1KaWwUSkDEKPseVY-z00kQJfpfVFdJCXPv9_CrwVZPMhg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jul 8, 2021 at 6:31 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> Hi all,
>
> When reading the doc of ALTER SUBSCRIPTION I realized that 'refresh
> options' in the following paragraph is not tagged:
>
> ---
> Additionally, refresh options as described under REFRESH PUBLICATION
> may be specified, except in the case of DROP PUBLICATION.
> ---
>
> When I read it for the first time, I got confused because we actually
> have the 'refresh' option and this description in the paragraph of the
> 'refresh' option. I think we can improve it by changing to
> '<replaceable>refresh_option</replaceable>'. Thoughts?
>

I see that one can get confused but how about changing it to
"Additionally, refresh options as described under <literal>REFRESH
PUBLICATION</literal> (<replaceable>refresh_option</replaceable>) may
be specified,.."? I think keeping "refresh options" in the text would
be good because there could be multiple such options.

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Mahendra Singh Thalor 2021-08-07 06:43:38 Re: Support reset of Shared objects statistics in "pg_stat_reset" function
Previous Message Mahendra Singh Thalor 2021-08-07 06:19:24 Re: Support reset of Shared objects statistics in "pg_stat_reset" function