| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Cc: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Notify downstream to discard the streamed transaction which was aborted due to crash. |
| Date: | 2023-01-07 10:30:32 |
| Message-ID: | CAA4eK1KYUiFzqGXh0u2z9+dCyBTbQvjrkvZLudq8HE59ZzMmaw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jan 6, 2023 at 11:18 AM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
>
> >
> > To fix it, One idea is to send a stream abort message when we are cleaning up
> > crashed transaction on publisher(e.g. in ReorderBufferAbortOld()). And here is
> > a tiny patch which changes the same. I have confirmed that the bug is fixed and
> > all regression tests pass. I didn't add a testcase because we need to make sure
> > the crash happens before all the WAL logged transactions data are decoded which
> > doesn't seem easy to write a stable test for this.
> >
> > Thoughts ?
>
> Fix looks good to me. Thanks for working on this.
>
Pushed!
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2023-01-07 10:47:59 | Re: Generating code for query jumbling through gen_node_support.pl |
| Previous Message | David Rowley | 2023-01-07 09:46:43 | Allow DISTINCT to use Incremental Sort |