| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Srinath Reddy Sadipiralla <srinath2133(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fix "unexpected logical decoding status change" error; from concurrent logical decoding activation |
| Date: | 2026-07-29 10:21:06 |
| Message-ID: | CAA4eK1KRwzSOvNuJ8FVFYzzp4L3uUf_Z_iHDbmnT2pG6y6nfwQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jul 27, 2026 at 10:10 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> Agreed and pushed the 0001 patch.
>
> I've updated the comments in the previous-0002 patch, please review it.
>
In the comments you mentioned 'already-visible slot' as follows: "Our
already-visible slot guarantees that this check doesn't miss ..." but
we normally don't use visibility term for slots (it is used primarily
for tuples). I think you mean to say that its in_use flag is set, I
tried to slightly modify that part of the comment in the attached.
See, if that looks okay to you.
Apart from that, I ran the added test on my Windows machine and it
failed, attached find the required log.
--
With Regards,
Amit Kapila.
| Attachment | Content-Type | Size |
|---|---|---|
| v4_topup_comment-fixup.patch | application/octet-stream | 1.1 KB |
| 051_effective_wal_level_standby5.log | application/octet-stream | 3.3 KB |
| regress_log_051_effective_wal_level | application/octet-stream | 21.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2026-07-29 10:28:22 | Re: [Patch] Don't stop a `vacuumdb --all` on a connection failure |
| Previous Message | Ilia Evdokimov | 2026-07-29 10:14:46 | Re: Show estimated number of groups for IncrementalSort in EXPLAIN |