| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, "Takamichi Osumi (Fujitsu)" <osumi(dot)takamichi(at)fujitsu(dot)com> |
| Subject: | Re: PGdoc: add missing ID attribute to create_subscription.sgml |
| Date: | 2023-03-28 12:23:09 |
| Message-ID: | CAA4eK1KNVhUhxWPw66REodjjW3_-HTyUJKQYk-n9gb+-HU1jVg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 28, 2023 at 1:00 PM Hayato Kuroda (Fujitsu)
<kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
>
> Dear Amit,
>
> Thank you for reviewing! PSA new version.
>
> > Isn't it better to move the link-related part to the next line
> > wherever possible? Currently, it looks bit odd.
>
> Previously I preferred not to add a new line inside the <link> tag, but it caused
> long-line. So I adjusted them not to be too short/long length.
>
There is no need to break the link line. See attached.
--
With Regards,
Amit Kapila.
| Attachment | Content-Type | Size |
|---|---|---|
| v7-0001-Add-XML-ID-attributes-to-create_subscription.sgml.patch | application/octet-stream | 17.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joe Conway | 2023-03-28 12:46:17 | Re: Add standard collation UNICODE |
| Previous Message | Damir Belyalov | 2023-03-28 12:22:57 | Re: POC PATCH: copy from ... exceptions to: (was Re: VLDB Features) |