Re: Hard to maintain duplication in contain_volatile_functions_not_nextval_walker

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Hard to maintain duplication in contain_volatile_functions_not_nextval_walker
Date: 2016-05-28 02:36:51
Message-ID: CAA4eK1KNEyv55WgrktshUQOzU4JwT_aupCkTaQuP_=zYJsLoNA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, May 28, 2016 at 12:28 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> Hi,
>
> contain_volatile_functions_walker is duplicated, near entirely, in
> contain_volatile_functions_not_nextval_walker.
>

Previously, I also had same observation.

> Wouldn't it have been better not to duplicate, and keep a flag about
> ignoring nextval in the context variable?
>

makes sense. +1 for doing it in the way as you are suggesting.

With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2016-05-28 03:29:36 Re: Parallel pg_dump's error reporting doesn't work worth squat
Previous Message Andres Freund 2016-05-28 00:57:59 Re: [GENERAL] Permission Denied Error on pg_xlog/RECOVERYXLOG file