| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | "Drouvot, Bertrand" <bdrouvot(at)amazon(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "Schneider (AWS), Jeremy" <schnjere(at)amazon(dot)com> |
| Subject: | Re: [bug] Logical Decoding of relation rewrite with toast does not reset toast_hash |
| Date: | 2021-08-12 09:38:19 |
| Message-ID: | CAA4eK1KMkoCsa2TiG---53gJts6FVRPCHEJ3bat-8PNZ8gPUgQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Aug 12, 2021 at 12:15 PM Drouvot, Bertrand <bdrouvot(at)amazon(dot)com> wrote:
>
> On 8/10/21 1:59 PM, Drouvot, Bertrand wrote:
> > Hi Amit,
> >
>
> The first version of the patch contained a change in
> ReorderBufferToastReplace() (to put the call to
> RelationIsValid(toast_rel) and display the error message when it is not
> valid before the call to ReorderBufferChangeMemoryUpdate()).
>
> That way we also avoid the failed assertion described in the first
> message of this thread (but would report the error message instead).
>
> Forgot to mention that I did not add this change in the new patch
> version
>
I think that is the right decision.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Itamar Gafni | 2021-08-12 10:00:24 | RE: [PATCH] OpenSSL: Mark underlying BIO with the appropriate type flags |
| Previous Message | Amit Kapila | 2021-08-12 09:36:23 | Re: pgsql: pgstat: Bring up pgstat in BaseInit() to fix uninitialized use o |