Re: Turning recovery.conf into GUCs

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: Josh Berkus <josh(at)agliodbs(dot)com>, Alex Shulgin <ash(at)commandprompt(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Jaime Casanova <jaime(at)2ndquadrant(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Turning recovery.conf into GUCs
Date: 2014-11-22 04:22:06
Message-ID: CAA4eK1KMcB-LGaWmKzF0gMp971u6O5qofmOauKvX2U49XGEfqA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Nov 22, 2014 at 12:24 AM, Stephen Frost <sfrost(at)snowman(dot)net> wrote:
>
> * Josh Berkus (josh(at)agliodbs(dot)com) wrote:
> > > Either way, from the code it is clear that we only stay in recovery if
> > > standby_mode is directly turned on. This makes the whole check for a
> > > specially named file unnecessary, IMO: we should just check the value
of
> > > standby_mode (which is off by default).
> >
> > So, what happens when someone does "pg_ctl promote"? Somehow
> > standby_mode needs to get set to "off". Maybe we write "standby_mode =
> > off" to postgresql.auto.conf?
>
> Uhh, and then not work for the sane folks who disable
> postgresql.auto.conf? No thanks..
>

What exactly you mean by 'disable postgresql.auto.conf', do you
mean user runs Alter System to remove that entry or manually disable
some particular entry?

By default postgresql.auto.conf is always read, so if there is any
setting present in that file, that will taken into consideration.

With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2014-11-22 11:20:18 some ideas from users
Previous Message Peter Geoghegan 2014-11-22 04:11:20 Re: HINTing on UPDATE foo SET foo.bar = ..;