| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Add memory_limit_hits to pg_stat_replication_slots |
| Date: | 2025-09-22 11:05:26 |
| Message-ID: | CAA4eK1KKAs0jrmYvY9UwWBKv7AdPvPRahifTWbttk8+-U6aU=A@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Sep 22, 2025 at 1:41 PM Bertrand Drouvot
<bertranddrouvot(dot)pg(at)gmail(dot)com> wrote:
>
> >
> > Since other statistics counter names are camel cases I think it's
> > better to follow that for the new counter.
>
> Makes sense, done with memoryLimitHits in v2 attached (that's the only change
> as compared with v1).
>
The memory_limit_hits doesn't go well with the other names in the
view. Can we consider memory_exceeded_count? I find
memory_exceeded_count (or memory_exceeds_count) more clear and
matching with the existing counters. Also, how about keeping it
immediately after slot_name in the view? Keeping it in the end after
total_bytes seems out of place.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | AIX PG user | 2025-09-22 11:09:53 | Re: AIX support |
| Previous Message | Ajin Cherian | 2025-09-22 10:51:14 | Re: Improve pg_sync_replication_slots() to wait for primary to advance |