Re: Transaction commits VS Transaction commits (with parallel) VS query mean time

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Transaction commits VS Transaction commits (with parallel) VS query mean time
Date: 2019-04-04 04:29:41
Message-ID: CAA4eK1KJ_g-HyW3jmNr+hwcL0z8X0971RqrccW2gTPksbAC6+g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Apr 3, 2019 at 10:45 AM Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com> wrote:
>
> Thanks for the review.
>
> While changing the approach to use the is_parallel_worker_flag, I thought
> that the rest of the stats are also not required to be updated and also those
> are any way write operations and those values are zero anyway for parallel
> workers.
>
> Instead of expanding the patch scope, I just changed to avoid the commit
> or rollback stats as discussed, and later we can target the handling of all the
> internal transactions and their corresponding stats.
>

The patch looks good to me. I have changed the commit message and ran
the pgindent in the attached patch. Can you once see if that looks
fine to you? Also, we should backpatch this till 9.6. So, can you
once verify if the change is fine in all bank branches? Also, test
with a force_parallel_mode option. I have already tested it with
force_parallel_mode = 'regress' in HEAD, please test it in back
branches as well.

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

Attachment Content-Type Size
0001-Avoid-counting-transaction-stats-for-parallel-worker_v5.patch application/octet-stream 4.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2019-04-04 04:35:59 Re: Refactoring the checkpointer's fsync request queue
Previous Message Tsunakawa, Takayuki 2019-04-04 04:25:36 RE: Re: reloption to prevent VACUUM from truncating empty pages at the end of relation