From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | Joel Jacobson <joel(at)trustly(dot)com> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Marko Tiikkaja <marko(at)trustly(dot)com> |
Subject: | Re: [COMMITTERS] pgsql: Provide much better wait information in pg_stat_activity. |
Date: | 2016-03-11 04:02:21 |
Message-ID: | CAA4eK1KHS=sKP=kihzi7ZVRY1_QYOuZbOFTpFtK3irfUcjPsBg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Fri, Mar 11, 2016 at 9:19 AM, Joel Jacobson <joel(at)trustly(dot)com> wrote:
>
> On Fri, Mar 11, 2016 at 9:36 AM, Robert Haas <robertmhaas(at)gmail(dot)com>
wrote:
> > Well, this was discussed. If we keep the Boolean "waiting" column,
then either:
>
> Oh, sorry for missing out on that discussion.
>
> > 1. We make it true only for heavyweight lock waits, and false for
> > other kinds of waits. That's pretty strange.
> > 2. We make it true for all kinds of waits that we now know how to
> > report. That still breaks compatibility.
>
> Why not 3: We make it true for exactly the same type of situations as
> in previous versions. Or is it not possible to do so for some reason?
>
Thats exactly the first point (1) of Robert. One thing that will be
strange according to me is that in some cases where waiting will be false,
but still wait_event and wait_event_type contain some wait information and
I think that will look odd to anybody new looking at the view.
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2016-03-11 04:14:56 | Re: [COMMITTERS] pgsql: Provide much better wait information in pg_stat_activity. |
Previous Message | Joel Jacobson | 2016-03-11 03:49:27 | Re: [COMMITTERS] pgsql: Provide much better wait information in pg_stat_activity. |
From | Date | Subject | |
---|---|---|---|
Next Message | Dilip Kumar | 2016-03-11 04:08:22 | Re: Move PinBuffer and UnpinBuffer to atomics |
Previous Message | Andres Freund | 2016-03-11 04:00:42 | Re: GinPageIs* don't actually return a boolean |