Re: Enhance pg_createsubscriber to create required standby.

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>, Shubham Khanna <khannashubham1197(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Enhance pg_createsubscriber to create required standby.
Date: 2025-07-25 10:41:09
Message-ID: CAA4eK1KHJYE2vbk5u=eeq=D_Kq4fji2e4WGtFGUhwS3fn9yu2g@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jun 18, 2025 at 10:43 AM David G. Johnston
<david(dot)g(dot)johnston(at)gmail(dot)com> wrote:
>
> On Tue, Jun 17, 2025 at 9:22 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>>
>>
>> As shown in Vignesh's email [1] (point 4), there could be multiple
>> additional parameters required for the first option suggested by you,
>> which will make it longer. Additionally, there are some other benefits
>> of having the second option (pg_createsubscriber --create-standby),
>> like better cleanup of contents during failures and better progress
>> reporting. Are you still against adding such an option?
>>
>> [1]: https://www.postgresql.org/message-id/CALDaNm1biZBMOzFMfHYzqrAeosJSD5YRG%3D82-pp6%2BJhALsfe6w%40mail.gmail.com
>>
>
> None of those benefits convince me that "let's write a shell script in C and put it under an annual feature release policy" is the way to go here.
>

I don't think it is equivalent to writing a simple script as you are
imagining, for example the future enhancements in this tool could make
such scripts require constant updates. Also, not sure providing Ctrl+C
or progress reporting would be any easier with scripting.

I feel this is a basic requirement to create a subscriber-node from
scratch and for that if we refer users for external scripts, it would
be inconvenient for users.

--
With Regards,
Amit Kapila.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2025-07-25 10:51:41 Re: Adding basic NUMA awareness
Previous Message Dave Cramer 2025-07-25 10:28:28 Re: More protocol.h replacements this time into walsender.c