| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | SATYANARAYANA NARLAPURAM <satyanarlapuram(at)gmail(dot)com>, Hou, Zhijie/侯 志杰 <houzj(dot)fnst(at)fujitsu(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [Patch] Fix check_pub_rdt bypass when origin is set in same ALTER SUBSCRIPTION |
| Date: | 2026-05-29 22:18:41 |
| Message-ID: | CAA4eK1KEPGO+pyQPe48UYUgh0Cu9D+PsVf5iftTuT6fF0kpwiA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, May 26, 2026 at 3:50 PM SATYANARAYANA NARLAPURAM
<satyanarlapuram(at)gmail(dot)com> wrote:
>
> HI hackers,
>
> When ALTER SUBSCRIPTION SET (retain_dead_tuples = true, origin = 'none')
> is used, the publisher version/recovery check was bypassed because the
> origin handling unconditionally overwrote check_pub_rdt to false.
>
> Fix by using |= instead of = so that the flag set by retain_dead_tuples
> cannot be cleared by a subsequent origin assignment in the same command.
>
Thanks for catching this. Your fix LGTM. I won't be able to commit
today as I have to travel. In the meantime, let's see if Hou-San or
others have any comments.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2026-05-29 22:25:12 | Re: Adding REPACK [concurrently] |
| Previous Message | Álvaro Herrera | 2026-05-29 22:16:02 | Re: logical: fix recomputation required LSN on restart_lsn-only advancement |