Re: Doc: CREATE_REPLICATION_SLOT command requires the plugin name

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Antonin Houska <ah(at)cybertec(dot)at>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Doc: CREATE_REPLICATION_SLOT command requires the plugin name
Date: 2022-02-01 11:28:51
Message-ID: CAA4eK1KBEyN6eEEe2zDjjNYtCk5HAz0P-eM9HCe-Wmi5AXXx5A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Feb 1, 2022 at 3:44 PM Antonin Houska <ah(at)cybertec(dot)at> wrote:
>
> I got a syntax error when using the command according to the existing
> documentation. The output_plugin parameter needs to be passed too.
>

Why do we need it for physical slots? The syntax in repl_gram.y is as follows:
/* CREATE_REPLICATION_SLOT slot TEMPORARY PHYSICAL [options] */
K_CREATE_REPLICATION_SLOT IDENT opt_temporary K_PHYSICAL create_slot_options
...
/* CREATE_REPLICATION_SLOT slot TEMPORARY LOGICAL plugin [options] */
| K_CREATE_REPLICATION_SLOT IDENT opt_temporary K_LOGICAL IDENT
create_slot_options

The logical slots do need output_plugin but not physical ones.

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Antonin Houska 2022-02-01 12:15:29 Re: Doc: CREATE_REPLICATION_SLOT command requires the plugin name
Previous Message Amit Kapila 2022-02-01 11:21:38 Re: row filtering for logical replication