Re: Removing unused parameter in SnapBuildGetOrBuildSnapshot

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Zhang Mingli <zmlpostgres(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com>
Subject: Re: Removing unused parameter in SnapBuildGetOrBuildSnapshot
Date: 2022-09-23 03:28:17
Message-ID: CAA4eK1KB=7QOq6MkXo=4wrpq3FkqRACfT6VwKGDLa4UkeLQa2Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Sep 21, 2022 at 8:11 PM Zhang Mingli <zmlpostgres(at)gmail(dot)com> wrote:
>
> On Sep 21, 2022, 22:22 +0800, Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com>, wrote:
>
> Hi hackers,
>
> Sharing a small patch to remove an unused parameter in SnapBuildGetOrBuildSnapshot function in snapbuild.c
>
> With commit 6c2003f8a1bbc7c192a2e83ec51581c018aa162f, SnapBuildBuildSnapshot no longer needs transaction id. This also makes the xid parameter in SnapBuildGetOrBuildSnapshot useless.
> I couldn't see a reason to keep it and decided to remove it.
>
> Regards,
> Melih
>
> +1, Good Catch.
>

LGTM.

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2022-09-23 03:32:48 Re: CI and test improvements
Previous Message Tom Lane 2022-09-23 02:48:01 Re: libpq error message refactoring