Re: Proposal: Make use of C99 designated initialisers for nulls/values arrays

On Sat, Oct 19, 2019 at 9:14 PM Stephen Frost <sfrost(at)snowman(dot)net> wrote:
>
> * Andres Freund (andres(at)anarazel(dot)de) wrote:
>
> > Especially not when the person suggesting to do so isn't
> > even doing the leg work to estimate the portability issues.
>
> I figured it was common knowledge that gcc/clang supported it just fine,
> which covers something like 90% of the buildfarm. I haven't got easy
> access to check others.
>

I have tried {} on Windows (MSVC-2017) and it is giving compilation error:

>\src\backend\access\transam\commit_ts.c(425): error C2059: syntax error: '}'
1>\src\backend\access\transam\commit_ts.c(426): error C2059: syntax error: '}'

The changed code looks like below:
Datum
pg_last_committed_xact(PG_FUNCTION_ARGS)
{
..
Datum values[2] = {};
bool nulls[2] = {};
..
}

Does this put an end to the option of using {} or do we want to
investigate something more?

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com