Re: [HACKERS] logical decoding of two-phase transactions

On Tue, Feb 23, 2021 at 7:43 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Mon, Feb 22, 2021 at 11:04 PM Markus Wanner <markus(at)bluegap(dot)ch> wrote:
> >
> > On 04.01.21 09:18, Amit Kapila wrote:
> > > Thanks, I have pushed the 0001* patch after making the above and a few
> > > other cosmetic modifications.
> >
> > That commit added the following snippet to the top of
> > ReorderBufferFinishPrepared:
> >
> > txn = ReorderBufferTXNByXid(rb, xid, true, NULL, commit_lsn, false);
> >
> > /* unknown transaction, nothing to do */
> > if (txn == NULL)
> > return;
> >
> > Passing true for the create argument seems like an oversight. I think
> > this should pass false and not ever (have to) create a ReorderBufferTXN
> > entry.
> >
>
> Right, I'll push a fix for this.
>

Pushed!

--
With Regards,
Amit Kapila.