| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: sequencesync worker race with REFRESH SEQUENCES |
| Date: | 2026-07-29 06:35:15 |
| Message-ID: | CAA4eK1K8Sf0sN9NYPeOLOejrqPWy9pS8Wx3+xNqo05FJi4CLxw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jul 29, 2026 at 8:35 AM Hayato Kuroda (Fujitsu)
<kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
>
> > Yes, that is correct. How about a comment as follows:
> > /*
> > * Lock the sequence so its identity (namespace and name) cannot change
> > * under us via a concurrent DROP, RENAME or SET SCHEMA while we read it.
> > * The lock is released immediately rather than at transaction end. The
> > * later synchronization does not depend on this captured identity
> > * remaining valid, as it re-opens the sequence and tolerates concurrent
> > * changes. Releasing early also avoids holding one lock per sequence,
> > * which could exhaust the lock table.
> > */
>
> LGTM.
>
Thanks, pushed now.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2026-07-29 06:55:08 | Re: sequencesync worker race with REFRESH SEQUENCES |
| Previous Message | Richard Guo | 2026-07-29 06:21:18 | Re: remove_useless_joins vs. bug #19560 |