Re: Reword messages using "as" instead of "because"

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>
Cc: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Reword messages using "as" instead of "because"
Date: 2025-09-18 03:13:48
Message-ID: CAA4eK1K84EPnfLvKBhvn0oHrt3cX36BFRGB9fF=XJ3+rgHeczA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Sep 17, 2025 at 8:53 AM Zhijie Hou (Fujitsu)
<houzj(dot)fnst(at)fujitsu(dot)com> wrote:
>
> >
> > In the above sentence, has advanced sounds like we have already advanced
> > but that is not the case. Also, use of into looks odd to me.
> > How about changing it to: "Retention is re-enabled because the apply process
> > can advance its xmin within the configured max_retention_duration of %u
> > ms."?
> >
> > Similarly for the first message, how about: "Retention is stopped because the
> > apply process could not advance its xmin within the configured
> > max_retention_duration of %u ms."?
>
> I think the suggested message aligns better with the implementation.
>
> I updated the message based on Horiguchi-San's revision. Additionally,
> 035_conflicts.pl has been modified, as it was waiting for the resume DETAIL
> message and this message has now been updated.
>

LGTM. Horiguchi-San, do let me know if you have suggestions here. I am
planning to push this tomorrow.

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2025-09-18 03:26:21 Re: Reword messages using "as" instead of "because"
Previous Message Yugo Nagata 2025-09-18 03:05:06 Re: psql: tab-completion support for COPY ... TO/FROM STDIN, STDOUT, and PROGRAM