| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Peter Geoghegan <pg(at)bowt(dot)ie>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: parallel vacuum comments |
| Date: | 2021-12-10 12:08:43 |
| Message-ID: | CAA4eK1K5E0Hsd-iBE2oO8WAGL6p+iagqWRPP=-9E1EHyrNtpCw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Dec 9, 2021 at 6:05 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> On Thu, Dec 9, 2021 at 7:44 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> Agreed with the above two points.
>
> I've attached updated patches that incorporated the above comments
> too. Please review them.
>
I have made the following minor changes to the 0001 patch: (a) An
assert was removed from dead_items_max_items() which I added back. (b)
Removed an unnecessary semicolon from one of the statements in
compute_parallel_vacuum_workers(). (c) Changed comments at a few
places. (d) moved all parallel_vacuum_* related functions together.
(e) ran pgindent and slightly modify the commit message.
Let me know what you think of the attached?
--
With Regards,
Amit Kapila.
| Attachment | Content-Type | Size |
|---|---|---|
| v8-0001-Improve-parallel-vacuum-implementation.patch | application/octet-stream | 52.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2021-12-10 13:08:52 | Re: Column Filtering in Logical Replication |
| Previous Message | Jakub Wartak | 2021-12-10 11:06:37 | RE: track_io_timing default setting |